chaokunyang commented on code in PR #2037: URL: https://github.com/apache/fury/pull/2037#discussion_r1944350109
########## python/pyfury/_fury.py: ########## @@ -82,11 +82,15 @@ # Key is null, value type is declared type, and ref tracking for value is disabled. NULL_KEY_VALUE_DECL_TYPE = KEY_HAS_NULL | VALUE_DECL_TYPE # Key is null, value type is declared type, and ref tracking for value is enabled. -NULL_KEY_VALUE_DECL_TYPE_TRACKING_REF = KEY_HAS_NULL | VALUE_DECL_TYPE | TRACKING_VALUE_REF +NULL_KEY_VALUE_DECL_TYPE_TRACKING_REF = ( Review Comment: could we reserve those parameters in _serializer.py, it's used by map serializer only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
