LouisLou2 opened a new pull request, #2186: URL: https://github.com/apache/fury/pull/2186
<!-- **Thanks for contributing to Fury.** **If this is your first time opening a PR on Fury, you can refer to [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fury (incubating)** community has restrictions on the naming of PR titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md). - Fury has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## What does this PR do? This PR adds a unit test case for the previously fixed bug in the `readVarUint36Small()` method (PR #XXXX). The test verifies that the method now correctly handles the maximum 36-bit value (`0b111111111111111111111111111111111111L`) regardless of whether it's read from a buffer with 8 or 9 bytes of remaining space. The test confirms that: 1. The fast path (buffer size 9) correctly reads the value 2. The slow path (buffer size 8) correctly reads the same value 3. The results from both paths match as expected ## Related issues - #2110 [Java] Inconsistent readVarUint36Small() behavior depending on remaining buffer size ## Does this PR introduce any user-facing change? - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach benchmark data here. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
