LouisLou2 commented on code in PR #2187:
URL: https://github.com/apache/fury/pull/2187#discussion_r2058358273
##########
dart/packages/fury/lib/src/const/lang.dart:
##########
@@ -19,15 +19,15 @@
/// Language supported by fury.
enum Language{
- XLANG,
- JAVA,
- PYTHON,
- CPP,
- GO,
- JAVASCRIPT,
- RUST,
- DART;
+ xlang,
Review Comment:
@pandalee99 Thanks for noticing the difference.
The lowercase style (`xlang`, `java`) follows Dart's official style
guidelines which specifically recommend lowerCamelCase for constants and enum
values:
https://dart.dev/effective-dart/style#prefer-using-lowercamelcase-for-constant-names
Dart explicitly discourages using the SCREAMING_CAPS style that's common in
other languages like Java.
I'm following these guidelines to ensure the Dart implementation is
idiomatic within its ecosystem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
