chaokunyang commented on code in PR #2191:
URL: https://github.com/apache/fury/pull/2191#discussion_r2084447686
##########
java/fury-core/src/main/java/org/apache/fury/builder/CompatibleCodecBuilder.java:
##########
@@ -341,9 +341,13 @@ private Expression writeEmbedTypeFieldValue(
Expression bean, Expression buffer, FieldInfo fieldInfo) {
Descriptor descriptor = createDescriptor(fieldInfo);
walkPath.add(descriptor.getDeclaringClass() + descriptor.getName());
+ boolean nullable = false;
+ if (!descriptor.getTypeRef().isPrimitive()) {
Review Comment:
Could we add a nullable method in Descriptor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
