Philipp Hörist pushed to branch master at gajim / gajim
Commits:
04b70bf2 by Philipp Hörist at 2018-09-17T21:38:52Z
Fix trailing-comma-tuple pylint errors
- - - - -
206b87d7 by Philipp Hörist at 2018-09-17T21:42:23Z
Update pylint error list
Check for R1707 trailing-comma-tuple
- - - - -
6 changed files:
- .gitlab-ci.yml
- gajim/command_system/implementation/custom.py
- gajim/command_system/implementation/standard.py
- gajim/common/idle.py
- gajim/common/protocol/bytestream.py
- scripts/dev/pre-push-tests.sh
Changes:
=====================================
.gitlab-ci.yml
=====================================
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -19,7 +19,7 @@ run-mypy:
run-pylint:
stage: test
script:
- - pylint3 --jobs=2 --additional-builtins=_ --disable=all
--enable=C0201,C0325,C1801,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0106,E0107,E0108,E0202,E0221,E0222,E0235,E0501,E0502,E0503,E0602,E0603,E0604,E0701,E0702,E1001,E1002,E1003,E1004,E1111,E1120,E1121,E1122,E1123,E1124,E1125,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701,R0123,R0205,R1703,W0102,W0611,W0612,W0621,W0702,W1201,W1202
gajim
+ - pylint3 --jobs=2 --additional-builtins=_ --disable=all
--enable=C0201,C0325,C1801,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0106,E0107,E0108,E0202,E0221,E0222,E0235,E0501,E0502,E0503,E0602,E0603,E0604,E0701,E0702,E1001,E1002,E1003,E1004,E1111,E1120,E1121,E1122,E1123,E1124,E1125,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701,R0123,R0205,R1703,R1707,W0102,W0611,W0612,W0621,W0702,W1201,W1202
gajim
run-build:
stage: build
=====================================
gajim/command_system/implementation/custom.py
=====================================
--- a/gajim/command_system/implementation/custom.py
+++ b/gajim/command_system/implementation/custom.py
@@ -77,7 +77,7 @@ class CustomChatCommands(CommandContainer):
"""
AUTOMATIC = True
- HOSTS = ChatCommands,
+ HOSTS = (ChatCommands,)
@command("squal", "bawl")
def sing(self):
@@ -100,7 +100,7 @@ class CustomPrivateChatCommands(CommandContainer):
"""
AUTOMATIC = True
- HOSTS = PrivateChatCommands,
+ HOSTS = (PrivateChatCommands,)
@command
#Example string. Do not translate
@@ -116,7 +116,7 @@ class CustomGroupChatCommands(CommandContainer):
"""
AUTOMATIC = True
- HOSTS = GroupChatCommands,
+ HOSTS = (GroupChatCommands,)
@command
def fetch(self):
=====================================
gajim/command_system/implementation/standard.py
=====================================
--- a/gajim/command_system/implementation/standard.py
+++ b/gajim/command_system/implementation/standard.py
@@ -225,7 +225,7 @@ class StandardChatCommands(CommandContainer):
"""
AUTOMATIC = True
- HOSTS = ChatCommands,
+ HOSTS = (ChatCommands,)
class StandardPrivateChatCommands(CommandContainer):
"""
@@ -234,7 +234,7 @@ class StandardPrivateChatCommands(CommandContainer):
"""
AUTOMATIC = True
- HOSTS = PrivateChatCommands,
+ HOSTS = (PrivateChatCommands,)
class StandardGroupChatCommands(CommandContainer):
"""
@@ -243,7 +243,7 @@ class StandardGroupChatCommands(CommandContainer):
"""
AUTOMATIC = True
- HOSTS = GroupChatCommands,
+ HOSTS = (GroupChatCommands,)
@command
@doc(_("Clear the text window"))
=====================================
gajim/common/idle.py
=====================================
--- a/gajim/common/idle.py
+++ b/gajim/common/idle.py
@@ -103,9 +103,9 @@ class XssIdleMonitor:
raise OSError('libX11 could not be found.')
libX11 = ctypes.cdll.LoadLibrary(libX11path)
libX11.XOpenDisplay.restype = display_p
- libX11.XOpenDisplay.argtypes = ctypes.c_char_p,
+ libX11.XOpenDisplay.argtypes = (ctypes.c_char_p,)
libX11.XDefaultRootWindow.restype = xid
- libX11.XDefaultRootWindow.argtypes = display_p,
+ libX11.XDefaultRootWindow.argtypes = (display_p,)
libXsspath = ctypes.util.find_library('Xss')
if libXsspath is None:
=====================================
gajim/common/protocol/bytestream.py
=====================================
--- a/gajim/common/protocol/bytestream.py
+++ b/gajim/common/protocol/bytestream.py
@@ -410,7 +410,7 @@ class ConnectionSocks5Bytestream(ConnectionBytestream):
except socket.gaierror:
from gajim.common.connection_handlers_events import
InformationEvent
app.nec.push_incoming_event(
- InformationEvent(None, dialog_name='wrong-host')),
+ InformationEvent(None, dialog_name='wrong-host'))
def _add_addiditional_streamhosts_to_query(self, query, file_props):
sender = file_props.sender
=====================================
scripts/dev/pre-push-tests.sh
=====================================
--- a/scripts/dev/pre-push-tests.sh
+++ b/scripts/dev/pre-push-tests.sh
@@ -1,2 +1,2 @@
mypy -p gajim.common.modules --follow-imports=skip
-pylint --jobs=2 --additional-builtins=_ --disable=all
--enable=C0201,C0325,C1801,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0106,E0107,E0108,E0202,E0221,E0222,E0235,E0501,E0502,E0503,E0602,E0603,E0604,E0701,E0702,E1001,E1002,E1003,E1004,E1111,E1120,E1121,E1122,E1123,E1124,E1125,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701,R0123,R0205,R1703,W0102,W0611,W0612,W0621,W0702,W1201,W1202
gajim
+pylint --jobs=2 --additional-builtins=_ --disable=all
--enable=C0201,C0325,C1801,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0106,E0107,E0108,E0202,E0221,E0222,E0235,E0501,E0502,E0503,E0602,E0603,E0604,E0701,E0702,E1001,E1002,E1003,E1004,E1111,E1120,E1121,E1122,E1123,E1124,E1125,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701,R0123,R0205,R1703,R1707,W0102,W0611,W0612,W0621,W0702,W1201,W1202
gajim
View it on GitLab:
https://dev.gajim.org/gajim/gajim/compare/67bb5a57c36149d0a91fd207a75fef76cddae8b8...206b87d7b7cdb7e9c871f9a69946a8bbe70d76ec
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/compare/67bb5a57c36149d0a91fd207a75fef76cddae8b8...206b87d7b7cdb7e9c871f9a69946a8bbe70d76ec
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list
[email protected]
https://lists.gajim.org/cgi-bin/listinfo/commits
