Philipp Hörist pushed to branch master at gajim / gajim
Commits:
37d93c8b by Philipp Hörist at 2026-08-10T22:03:08+02:00
refactor: Passwords: Remove custom typing stubs
- - - - -
5 changed files:
- gajim/common/passwords.py
- − typings/keyring/__init__.pyi
- − typings/keyring/backend.pyi
- − typings/keyring/core.pyi
- − typings/keyring/errors.pyi
Changes:
=====================================
gajim/common/passwords.py
=====================================
@@ -17,6 +17,9 @@
import logging
import keyring
+import keyring.backend
+import keyring.core
+import keyring.errors
from gajim.common import app
from gajim.common.util.version import package_version
@@ -55,7 +58,7 @@ def init(self) -> None:
self.backend = keyring.get_keyring()
log.info("Select %s backend", self.backend)
- self._is_keyring_available = keyring.core.recommended(self.backend)
+ self._is_keyring_available = keyring.core.recommended(self.backend) #
type: ignore
class SecretPasswordStorage:
@@ -75,7 +78,7 @@ def save_password(account_name: str, password: str) -> bool:
try:
log.info("Save password to keyring")
- _interface.backend.set_password("gajim", account_jid, password)
+ _interface.backend.set_password("gajim", account_jid, password) #
type: ignore
return True
except Exception:
log.exception("Save password failed")
=====================================
typings/keyring/__init__.pyi deleted
=====================================
@@ -1,4 +0,0 @@
-from . import backend as backend
-from . import core as core
-from . import errors as errors
-from .core import get_keyring as get_keyring
=====================================
typings/keyring/backend.pyi deleted
=====================================
@@ -1,9 +0,0 @@
-from typing import Any
-
-class KeyringBackend:
- def get_password(self, service: str, username: str) -> str | None: ...
- def set_password(self, service: str, username: str, password: str) ->
None: ...
- def delete_password(self, service: str, username: str) -> None: ...
- def with_properties(self, **kwargs: Any) -> KeyringBackend: ...
-
-def get_all_keyring() -> list[KeyringBackend]: ...
=====================================
typings/keyring/core.pyi deleted
=====================================
@@ -1,7 +0,0 @@
-from keyring.backend import KeyringBackend
-
-def get_password(service_name: str, username: str) -> str | None: ...
-def set_password(service_name: str, username: str, password: str) -> None: ...
-def delete_password(service_name: str, username: str) -> None: ...
-def recommended(backend: KeyringBackend) -> bool: ...
-def get_keyring() -> KeyringBackend: ...
=====================================
typings/keyring/errors.pyi deleted
=====================================
@@ -1,6 +0,0 @@
-class KeyringError(Exception): ...
-class PasswordSetError(KeyringError): ...
-class PasswordDeleteError(KeyringError): ...
-class InitError(KeyringError): ...
-class KeyringLocked(KeyringError): ...
-class NoKeyringError(KeyringError): ...
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/37d93c8b2a4fe05b16543bd2dac7188e5ad08965
--
View it on GitLab:
https://dev.gajim.org/gajim/gajim/-/commit/37d93c8b2a4fe05b16543bd2dac7188e5ad08965
You're receiving this email because of your account on dev.gajim.org.
_______________________________________________
Commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
