GEODE-2449. Don't throw exception on redis port of zero when Redis service is not found.
We would like to have the ability to tell the difference between settings that are unset and those that are set to zero, but for the moment we can't. So that's how it is. It may be that we'll have to not allow starting a Redis host by setting a port number of zero in config, or that it will just be less reliable. Project: http://git-wip-us.apache.org/repos/asf/geode/repo Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/a1116189 Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/a1116189 Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/a1116189 Branch: refs/heads/feature/GEODE-2449 Commit: a1116189eb25c2209e21685386d9acfcf6fbdb9e Parents: f990e79 Author: Galen O'Sullivan <gosulli...@pivotal.io> Authored: Mon Feb 13 23:48:01 2017 -0800 Committer: Galen O'Sullivan <gosulli...@pivotal.io> Committed: Mon Feb 13 23:48:01 2017 -0800 ---------------------------------------------------------------------- .../java/org/apache/geode/internal/cache/GemFireCacheImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/geode/blob/a1116189/geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java b/geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java index 94532c6..dc8facc 100755 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java @@ -1363,7 +1363,7 @@ public class GemFireCacheImpl GeodeRedisService geodeRedisService = getService(GeodeRedisService.class); if (geodeRedisService != null) { geodeRedisService.start(); - } else if (system.getConfig().getRedisPort() >= 0) { + } else if (system.getConfig().getRedisPort() > 0) { throw new GemFireConfigException( "Geode Redis Service could not be started because it was not registered as a service"); }
