This is an automated email from the ASF dual-hosted git repository.
udo pushed a commit to branch feature/GEODE-3604
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/feature/GEODE-3604 by this
push:
new e6ab818 moved UnknownProtobufPrimitiveType.java to different package
changed method signature in OperationContext.java
e6ab818 is described below
commit e6ab818e8084690aa546c3fb77f4a99c56b25cf6
Author: kohlmu-pivotal <[email protected]>
AuthorDate: Thu Sep 14 12:30:17 2017 -0700
moved UnknownProtobufPrimitiveType.java to different package
changed method signature in OperationContext.java
---
.../exception/UnknownProtobufPrimitiveType.java | 2 +-
.../apache/geode/protocol/protobuf/OperationContext.java | 4 ++--
.../protobuf/utilities/ProtobufPrimitiveTypes.java | 6 +++++-
.../protocol/protobuf/utilities/ProtobufUtilities.java | 4 ++--
.../protobuf/utilities/ProtobufUtilitiesJUnitTest.java | 15 ++++++++-------
5 files changed, 18 insertions(+), 13 deletions(-)
diff --git
a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/exception/UnknownProtobufPrimitiveType.java
b/geode-protobuf/src/main/java/org/apache/geode/protocol/exception/UnknownProtobufPrimitiveType.java
similarity index 93%
rename from
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/exception/UnknownProtobufPrimitiveType.java
rename to
geode-protobuf/src/main/java/org/apache/geode/protocol/exception/UnknownProtobufPrimitiveType.java
index ca1dc72..eac9900 100644
---
a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/exception/UnknownProtobufPrimitiveType.java
+++
b/geode-protobuf/src/main/java/org/apache/geode/protocol/exception/UnknownProtobufPrimitiveType.java
@@ -12,7 +12,7 @@
* or implied. See the License for the specific language governing permissions
and limitations under
* the License.
*/
-package org.apache.geode.protocol.protobuf.utilities.exception;
+package org.apache.geode.protocol.exception;
import org.apache.geode.annotations.Experimental;
diff --git
a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
index 1b04e54..6885342 100644
---
a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
+++
b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
@@ -37,11 +37,11 @@ public class OperationContext<OperationRequest,
OperationResponse> {
this.operationHandler = operationHandler;
this.fromRequest = fromRequest;
this.toResponse = toResponse;
- this.toErrorResponse = OperationContext::makeErrorBuilder;
+ this.toErrorResponse = this::makeErrorBuilder;
accessPermissionRequired = permissionRequired;
}
- public static ClientProtocol.Response.Builder makeErrorBuilder(
+ private ClientProtocol.Response.Builder makeErrorBuilder(
ClientProtocol.ErrorResponse errorResponse) {
return
ClientProtocol.Response.newBuilder().setErrorResponse(errorResponse);
}
diff --git
a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java
b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java
index 90ce308..c847cda 100644
---
a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java
+++
b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java
@@ -15,8 +15,12 @@
package org.apache.geode.protocol.protobuf.utilities;
import org.apache.geode.annotations.Experimental;
-import
org.apache.geode.protocol.protobuf.utilities.exception.UnknownProtobufPrimitiveType;
+import org.apache.geode.protocol.exception.UnknownProtobufPrimitiveType;
+
+/**
+ * This enums primary use is to serialize Java primitive types with Protobuf
+ */
@Experimental
public enum ProtobufPrimitiveTypes {
diff --git
a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
index 4da8723..927f8ba 100644
---
a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
+++
b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
@@ -21,10 +21,10 @@ import org.apache.geode.cache.Region;
import org.apache.geode.cache.RegionAttributes;
import org.apache.geode.internal.protocol.protobuf.BasicTypes;
import org.apache.geode.internal.protocol.protobuf.ClientProtocol;
+import org.apache.geode.internal.protocol.protobuf.RegionAPI;
+import org.apache.geode.protocol.exception.UnknownProtobufPrimitiveType;
import org.apache.geode.protocol.protobuf.EncodingTypeTranslator;
import org.apache.geode.protocol.protobuf.ProtobufSerializationService;
-import org.apache.geode.internal.protocol.protobuf.RegionAPI;
-import
org.apache.geode.protocol.protobuf.utilities.exception.UnknownProtobufPrimitiveType;
import org.apache.geode.serialization.SerializationService;
import
org.apache.geode.serialization.exception.UnsupportedEncodingTypeException;
import
org.apache.geode.serialization.registry.exception.CodecNotRegisteredForTypeException;
diff --git
a/geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilitiesJUnitTest.java
b/geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilitiesJUnitTest.java
index 14b4b77..339e4b7 100644
---
a/geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilitiesJUnitTest.java
+++
b/geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilitiesJUnitTest.java
@@ -15,17 +15,18 @@
package org.apache.geode.protocol.protobuf.utilities;
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+
+import java.nio.charset.Charset;
+
import com.google.protobuf.ByteString;
-import org.apache.geode.internal.protocol.protobuf.BasicTypes;
-import
org.apache.geode.protocol.protobuf.utilities.exception.UnknownProtobufPrimitiveType;
-import org.apache.geode.test.junit.categories.UnitTest;
import org.junit.Test;
import org.junit.experimental.categories.Category;
-import java.nio.charset.Charset;
-
-import static org.junit.Assert.assertArrayEquals;
-import static org.junit.Assert.assertEquals;
+import org.apache.geode.internal.protocol.protobuf.BasicTypes;
+import org.apache.geode.protocol.exception.UnknownProtobufPrimitiveType;
+import org.apache.geode.test.junit.categories.UnitTest;
@Category(UnitTest.class)
public class ProtobufUtilitiesJUnitTest {
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
