This is an automated email from the ASF dual-hosted git repository. klund pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push: new 34ec001 GEODE-5637: disable SingleHopClientExecutorWithLoggingIntegrationTest 34ec001 is described below commit 34ec00147c01b043ebc5094e6e699469756245b4 Author: Kirk Lund <kl...@apache.org> AuthorDate: Tue Aug 28 16:21:54 2018 -0700 GEODE-5637: disable SingleHopClientExecutorWithLoggingIntegrationTest This test is super flaky and seems to consistently fail on Windows. It's trying to use SystemErrRule to test logging which doesn't really work very well. I think the test needs to be rewritten with a Log4J2 Appender instead of trying to use stdout or stderr. I'm going to disable it with Ignore until I can get this rewritten. Discussed with and reviewed by Sai. --- .../internal/SingleHopClientExecutorWithLoggingIntegrationTest.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/geode-core/src/integrationTest/java/org/apache/geode/cache/client/internal/SingleHopClientExecutorWithLoggingIntegrationTest.java b/geode-core/src/integrationTest/java/org/apache/geode/cache/client/internal/SingleHopClientExecutorWithLoggingIntegrationTest.java index 0967a70..48aa2ae 100644 --- a/geode-core/src/integrationTest/java/org/apache/geode/cache/client/internal/SingleHopClientExecutorWithLoggingIntegrationTest.java +++ b/geode-core/src/integrationTest/java/org/apache/geode/cache/client/internal/SingleHopClientExecutorWithLoggingIntegrationTest.java @@ -20,9 +20,11 @@ import static java.util.concurrent.TimeUnit.MINUTES; import static org.assertj.core.api.Assertions.assertThat; import static org.awaitility.Awaitility.await; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.contrib.java.lang.system.SystemErrRule; +import org.junit.contrib.java.lang.system.SystemOutRule; import org.junit.experimental.categories.Category; import org.apache.geode.test.junit.categories.ClientServerTest; @@ -37,11 +39,15 @@ public class SingleHopClientExecutorWithLoggingIntegrationTest { @Rule public SystemErrRule systemErrRule = new SystemErrRule().enableLog(); + @Rule + public SystemOutRule systemOutRule = new SystemOutRule().enableLog(); + /** * Refer: GEODE-2109 This test verifies that any exception thrown from forked thread is logged * into log. */ @Test + @Ignore("Until GEODE-5637 is fixed") public void submittedTaskShouldLogFailure() { String message = "I am expecting this to be logged";