svn commit: r1417250 - in /giraph/trunk: CHANGELOG giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java

[aching]

Author: aching
Date: Wed Dec  5 00:43:35 2012
New Revision: 1417250

URL: http://svn.apache.org/viewvc?rev=1417250&view=rev
Log:
GIRAPH-395: No need to make HashWorkerPartitioner thread-safe. (aching)

Modified:
    giraph/trunk/CHANGELOG
    
giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java

Modified: giraph/trunk/CHANGELOG
URL: 
http://svn.apache.org/viewvc/giraph/trunk/CHANGELOG?rev=1417250&r1=1417249&r2=1417250&view=diff
==============================================================================
--- giraph/trunk/CHANGELOG (original)
+++ giraph/trunk/CHANGELOG Wed Dec  5 00:43:35 2012
@@ -1,6 +1,8 @@
 Giraph Change Log
 
 Release 0.2.0 - unreleased
+  GIRAPH-395: No need to make HashWorkerPartitioner thread-safe. (aching)
+
   GIRAPH-441: Keep track of connected channels in NettyServer (majakabiljo)
 
   GIRAPH-440: ProgressableUtils - TimeoutException from future.get shouldn't 

Modified: 
giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
URL: 
http://svn.apache.org/viewvc/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java?rev=1417250&r1=1417249&r2=1417250&view=diff
==============================================================================
--- 
giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
 (original)
+++ 
giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
 Wed Dec  5 00:43:35 2012
@@ -44,11 +44,10 @@ public class HashWorkerPartitioner<I ext
     V extends Writable, E extends Writable, M extends Writable>
     implements WorkerGraphPartitioner<I, V, E, M> {
   /**
-   * Mapping of the vertex ids to {@link PartitionOwner}.  Needs to be
-   * thread-safe (hence CopyOnWriteArrayList).
+   * Mapping of the vertex ids to {@link PartitionOwner}.
    */
   protected List<PartitionOwner> partitionOwnerList =
-      Lists.newCopyOnWriteArrayList();
+      Lists.newArrayList();
 
   @Override
   public PartitionOwner createPartitionOwner() {
@@ -115,8 +114,6 @@ public class HashWorkerPartitioner<I ext
 
   @Override
   public Collection<? extends PartitionOwner> getPartitionOwners() {
-    synchronized (partitionOwnerList) {
-      return partitionOwnerList;
-    }
+    return partitionOwnerList;
   }
 }