SinghAsDev commented on code in PR #4859:
URL: https://github.com/apache/incubator-gluten/pull/4859#discussion_r1520432612
##########
shims/spark34/src/main/scala/io/glutenproject/sql/shims/spark34/Spark34Shims.scala:
##########
@@ -252,4 +254,45 @@ class Spark34Shims extends SparkShims {
def getAnalysisExceptionPlan(ae: AnalysisException): Option[LogicalPlan] = {
ae.plan
}
+
+ override def getKeyGroupedPartitioning(batchScan: BatchScanExec):
Option[Seq[Expression]] = {
+ batchScan.keyGroupedPartitioning
+ }
+
+ override def getCommonPartitionValues(
+ batchScan: BatchScanExec): Option[Seq[(InternalRow, Int)]] = {
+ batchScan.commonPartitionValues
+ }
+
+ override def orderPartitions(
Review Comment:
The partitions are ordered when partitions are accessed in
wholestagecodegen, since we override wholestagecodegen we need to handle in
transformer layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
