zzcclp commented on code in PR #4708:
URL: https://github.com/apache/incubator-gluten/pull/4708#discussion_r1520657117
##########
backends-clickhouse/src/main/scala/io/glutenproject/execution/CHHashAggregateExecTransformer.scala:
##########
@@ -428,15 +434,20 @@ case class CHHashAggregateExecPullOutHelper(
ExpressionMappings.expressionExtensionTransformer.extensionExpressionsMapping.contains(
aggregateFunc.getClass)
) {
- ExpressionMappings.expressionExtensionTransformer
+ val option = ExpressionMappings.expressionExtensionTransformer
.getAttrsIndexForExtensionAggregateExpr(
aggregateFunc,
exp.mode,
exp,
aggregateAttributeList,
aggregateAttr,
index)
- } else {
+ if (option.nonEmpty) {
+ return option.get
Review Comment:
why it needs return directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
