WangGuangxin commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008557794
I believe the change on Gluten side is ready now. But the `ApproxPercentileAggregate` implements in velox has to make some minor modification, becasue when add intermediate data, it checks the row vector encoding in `addIntermediateImpl` https://github.com/facebookincubator/velox/blob/main/velox/functions/prestosql/aggregates/ApproxPercentileAggregate.cpp#L652 , I believe the encoding is guaranteed by `extractAccumulators` https://github.com/facebookincubator/velox/blob/main/velox/functions/prestosql/aggregates/ApproxPercentileAggregate.cpp#L262. But when it comes in Gluten, the output of PartialAgg are processed by Shuffle, which will flatten all vectors, so that the encoding is not guaranteed when added to FinalAgg. https://github.com/apache/incubator-gluten/blob/main/cpp/velox/shuffle/VeloxShuffleWriter.cc#L343 cc @zhztheplayer @liujiayi771 @ulysses-you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
