zhli1142015 commented on code in PR #5014:
URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531459439
##########
gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala:
##########
@@ -199,6 +199,10 @@ trait SparkPlanExecApi {
throw new UnsupportedOperationException("NaNvl is not supported")
}
+ def genUuidTransformer(substraitExprName: String, original: Uuid):
ExpressionTransformer = {
+ GenericExpressionTransformer(substraitExprName, Seq(), original)
Review Comment:
Uuid is a leaf expression, looks CH just treat it as leaf expression and
ignore the seed gerenated by spark.
Velox uuid can accept the seed parameter as a constant input. We get the
seed and pass it to velox. This is the reason we distinguish the implements.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
