liujiayi771 commented on code in PR #4952:
URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531653906
##########
gluten-core/src/main/scala/io/glutenproject/utils/PullOutProjectHelper.scala:
##########
@@ -57,12 +57,13 @@ trait PullOutProjectHelper {
protected def replaceExpressionWithAttribute(
expr: Expression,
- projectExprsMap: mutable.HashMap[Expression, NamedExpression]):
Expression =
+ projectExprsMap: mutable.HashMap[Expression, NamedExpression],
+ replaceBoundReference: Boolean = true): Expression =
Review Comment:
The default value should be false, and `GenerateExec` set it to true.
"replace" means using an `Alias` wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
