This is an automated email from the ASF dual-hosted git repository.

yangzy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new a88bffd23 [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten 
enabled (#5283)
a88bffd23 is described below

commit a88bffd23f57ff2f2e41fe8394dbdf69000ef920
Author: Yang Zhang <[email protected]>
AuthorDate: Mon Apr 8 10:00:03 2024 +0800

    [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten enabled (#5283)
---
 .../test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | 1 +
 .../apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala  | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
 
b/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index c63bd12cf..0488e1148 100644
--- 
a/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++ 
b/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -821,6 +821,7 @@ class VeloxTestSettings extends BackendTestSettings {
     .exclude("SPARK-23192: broadcast hint should be retained after using the 
cached data")
     .exclude("broadcast hint isn't propagated after a join")
     .exclude("broadcast join where streamed side's output partitioning is 
HashPartitioning")
+    .exclude("broadcast join where streamed side's output partitioning is 
PartitioningCollection")
 
   enableSuite[GlutenExistenceJoinSuite]
   enableSuite[GlutenInnerJoinSuite]
diff --git 
a/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala
 
b/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala
index 13317444c..207f316dd 100644
--- 
a/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala
+++ 
b/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala
@@ -36,12 +36,10 @@ class GlutenBroadcastJoinSuite extends BroadcastJoinSuite 
with GlutenTestsCommon
    * Create a new [[SparkSession]] running in local-cluster mode with unsafe 
and codegen enabled.
    */
   override def beforeAll(): Unit = {
-    super.beforeAll()
     val sparkBuilder = SparkSession
       .builder()
       .master("local-cluster[2,1,1024]")
       .appName("Gluten-UT")
-      .master(s"local[2]")
       .config(SQLConf.OPTIMIZER_EXCLUDED_RULES.key, 
ConvertToLocalRelation.ruleName)
       .config("spark.driver.memory", "1G")
       .config("spark.sql.adaptive.enabled", "true")
@@ -74,5 +72,8 @@ class GlutenBroadcastJoinSuite extends BroadcastJoinSuite 
with GlutenTestsCommon
         .config("spark.unsafe.exceptionOnMemoryLeak", "true")
         .getOrCreate()
     }
+    // BroadcastJoinSuiteBase will create SparkContext instance in its 
beforeAll call,
+    // which cause Gluten's plugin will not be injected.
+    super.beforeAll()
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to