Yohahaha commented on code in PR #5420:
URL: https://github.com/apache/incubator-gluten/pull/5420#discussion_r1574040071
##########
gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala:
##########
@@ -230,6 +230,8 @@ object ExpressionMappings {
Sig[ArrayRepeat](ARRAY_REPEAT),
Sig[ArrayRemove](ARRAY_REMOVE),
Sig[ArrayFilter](FILTER),
+ Sig[ArrayForAll](ALL_MATCH),
+ Sig[ArrayExists](ANY_MATCH),
Review Comment:
same.
##########
shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala:
##########
@@ -246,6 +246,8 @@ object ExpressionNames {
final val ARRAY_REPEAT = "array_repeat"
final val ARRAY_REMOVE = "array_remove"
final val FILTER = "filter"
+ final val ALL_MATCH = "all_match"
+ final val ANY_MATCH = "any_match"
Review Comment:
shims module is common for all backends, we should use vanilla spark's
function name here, and do conversion in each backends internal if needed.
so, I expect here should be `forall` and `exist`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
