JkSelf commented on code in PR #5480: URL: https://github.com/apache/incubator-gluten/pull/5480#discussion_r1575590215
########## backends-velox/src/main/scala/org/apache/spark/sql/execution/VeloxColumnarWriteFilesExec.scala: ########## @@ -254,20 +255,28 @@ class VeloxColumnarWriteFilesRDD( } } -class VeloxColumnarWriteFilesExec( +case class VeloxColumnarWriteFilesExec( Review Comment: @zhztheplayer Could you also add a comment at the class level explaining why it is necessary to extend BinaryExecNode? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
