This is an automated email from the ASF dual-hosted git repository.

hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new e633887c8 [VL] Add a bad test case that final aggregate of 
collect_list is fallen back while partial aggregate is not (#5649)
e633887c8 is described below

commit e633887c8447cb136015da5a817898a759739697
Author: Hongze Zhang <[email protected]>
AuthorDate: Wed May 8 11:23:58 2024 +0800

    [VL] Add a bad test case that final aggregate of collect_list is fallen 
back while partial aggregate is not (#5649)
---
 .../apache/gluten/execution/FallbackSuite.scala    | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git 
a/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala 
b/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
index 91024da1c..fbad525a2 100644
--- 
a/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
+++ 
b/backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
@@ -106,6 +106,40 @@ class FallbackSuite extends 
VeloxWholeStageTransformerSuite with AdaptiveSparkPl
     }
   }
 
+  // java.lang.NullPointerException
+  ignore("fallback final aggregate of collect_list") {
+    withSQLConf(
+      GlutenConfig.COLUMNAR_WHOLESTAGE_FALLBACK_THRESHOLD.key -> "1",
+      GlutenConfig.COLUMNAR_FALLBACK_IGNORE_ROW_TO_COLUMNAR.key -> "false",
+      GlutenConfig.EXPRESSION_BLACK_LIST.key -> "element_at"
+    ) {
+      runQueryAndCompare(
+        "SELECT sum(ele) FROM (SELECT c1, element_at(collect_list(c2), 1) as 
ele FROM tmp1 " +
+          "GROUP BY c1)") {
+        df =>
+          val columnarToRow = 
collectColumnarToRow(df.queryExecution.executedPlan)
+          assert(columnarToRow == 1)
+      }
+    }
+  }
+
+  // java.lang.NullPointerException
+  ignore("fallback final aggregate of collect_set") {
+    withSQLConf(
+      GlutenConfig.COLUMNAR_WHOLESTAGE_FALLBACK_THRESHOLD.key -> "1",
+      GlutenConfig.COLUMNAR_FALLBACK_IGNORE_ROW_TO_COLUMNAR.key -> "false",
+      GlutenConfig.EXPRESSION_BLACK_LIST.key -> "element_at"
+    ) {
+      runQueryAndCompare(
+        "SELECT sum(ele) FROM (SELECT c1, element_at(collect_set(c2), 1) as 
ele FROM tmp1 " +
+          "GROUP BY c1)") {
+        df =>
+          val columnarToRow = 
collectColumnarToRow(df.queryExecution.executedPlan)
+          assert(columnarToRow == 1)
+      }
+    }
+  }
+
   test("fallback with AQE read") {
     runQueryAndCompare(
       """


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to