zhztheplayer commented on code in PR #5655:
URL: https://github.com/apache/incubator-gluten/pull/5655#discussion_r1596208826
##########
gluten-ut/spark34/src/test/scala/org/apache/spark/sql/GlutenDataFrameAggregateSuite.scala:
##########
@@ -279,4 +283,55 @@ class GlutenDataFrameAggregateSuite extends
DataFrameAggregateSuite with GlutenS
randn(Random.nextLong())
).foreach(assertNoExceptions)
}
+
+ Seq(true, false).foreach {
+ value =>
+ testGluten(s"SPARK-31620: agg with subquery (whole-stage-codegen =
$value)") {
Review Comment:
> Do we need to also add this rewritten test for other spark versions?
Generally, we do that even though duplicate code is introduced.
For this case I felt it's OK to just test with one version (as long as it's
newer version, e.g., 3.4, 3.5). `collect_list` / `collect_set` in Spark
shouldn't have actual differences among these 4 Spark versions. Having it
tested with all Spark version definitely provides better coverage but we can
also make trade-off taking maintenance effort into account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
