marin-ma commented on code in PR #5675:
URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1597965285
##########
cpp/velox/shuffle/VeloxShuffleWriter.h:
##########
@@ -132,6 +132,8 @@ class VeloxShuffleWriter final : public ShuffleWriter {
arrow::Status split(std::shared_ptr<ColumnarBatch> cb, int64_t memLimit)
override;
+ arrow::Status sort(std::shared_ptr<ColumnarBatch> cb, int64_t memLimit)
override;
Review Comment:
@kerwin-zk After this patch, part of the existing APIs are only used for
hash-based shuffle, and the newly added ones are only used for sort-based
shuffle, which leads to a mixing of the code. It would be nice to separate the
APIs for both writer & reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
