This is an automated email from the ASF dual-hosted git repository.
yangzy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new f92518001 [CORE] Remove wrong comment for JoinSelectionOverrides
(#5730)
f92518001 is described below
commit f925180018bb4fc770fac1e394aa0ec7cb1c2ad8
Author: Mingliang Zhu <zhuml1...@gmail.com>
AuthorDate: Thu May 16 14:43:22 2024 +0800
[CORE] Remove wrong comment for JoinSelectionOverrides (#5730)
---
.../src/main/scala/org/apache/gluten/extension/StrategyOverrides.scala | 2 --
1 file changed, 2 deletions(-)
diff --git
a/gluten-core/src/main/scala/org/apache/gluten/extension/StrategyOverrides.scala
b/gluten-core/src/main/scala/org/apache/gluten/extension/StrategyOverrides.scala
index 28ce72546..d016eaccc 100644
---
a/gluten-core/src/main/scala/org/apache/gluten/extension/StrategyOverrides.scala
+++
b/gluten-core/src/main/scala/org/apache/gluten/extension/StrategyOverrides.scala
@@ -58,7 +58,6 @@ case class JoinSelectionOverrides(session: SparkSession)
hint: JoinHint,
forceShuffledHashJoin: Boolean): Seq[SparkPlan] = {
if (isBroadcastStage(left) || isBroadcastStage(right)) {
- // equal condition
val buildSide = if (isBroadcastStage(left)) BuildLeft else BuildRight
Seq(
BroadcastHashJoinExec(
@@ -70,7 +69,6 @@ case class JoinSelectionOverrides(session: SparkSession)
planLater(left),
planLater(right)))
} else {
- // non equal condition
// Generate BHJ here, avoid to do match in `JoinSelection` again.
val isHintEmpty = hint.leftHint.isEmpty && hint.rightHint.isEmpty
val buildSide = getBroadcastBuildSide(left, right, joinType, hint,
!isHintEmpty, conf)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
