jinchengchenghh commented on code in PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1604244527
########## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala: ########## @@ -18,6 +18,15 @@ package org.apache.gluten.expression import org.apache.gluten.substrait.expression.ExpressionNode +import org.apache.spark.sql.catalyst.expressions.Expression +import org.apache.spark.sql.types.DataType + trait ExpressionTransformer { Review Comment: For the code clean, I prefer to hold origin for all the `ExpressionTransformer`, what do you think? @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org