Yohahaha commented on PR #5770: URL: https://github.com/apache/incubator-gluten/pull/5770#issuecomment-2116552304
> > > @Yohahaha Seems to be that the block reservation code can be very suitable to become a individual `AllocationListener`. Would you like to check on that? > > > > > > I see it, listener can return the real changed bytes after move block reservation logic into it. > > I think we can wrap the underlying listener with a block-enabled listener only for creating ListenableMemoryAllocator. And use the underlying listener directly for ListenableArbitrator. > > The block-reservation code at least includes some kind of algorithms so let's have it isolated from other code. make sense for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
