PHILO-HE commented on PR #6464: URL: https://github.com/apache/incubator-gluten/pull/6464#issuecomment-2233306633
> > @kecookier, @jiangjiangtian, has Velox already supported pushing down HUGEINT filter? I note this pr was merged long time ago: [facebookincubator/velox#4484](https://github.com/facebookincubator/velox/pull/4484). Please help verify. > > I verify by pushing down the HUGEINT filter, and I get an exception: > > ``` > Caused by: java.lang.RuntimeException: Exception: VeloxRuntimeError > Error Source: RUNTIME > Error Code: INVALID_STATE > Retriable: False > Expression: !scanSpec_->filter() > Function: read > File: ../../velox/dwio/dwrf/reader/SelectiveDecimalColumnReader.cpp > Line: 114 > Stack trace: > # 0 _ZN8facebook5velox7process10StackTraceC1Ei > # 1 _ZN8facebook5velox14VeloxExceptionC1EPKcmS3_St17basic_string_viewIcSt11char_traitsIcEES7_S7_S7_bNS1_4TypeES7_ > # 2 _ZN8facebook5velox6detail14veloxCheckFailINS0_17VeloxRuntimeErrorENS1_22CompileTimeEmptyStringEEEvRKNS1_18VeloxCheckFailArgsET0_ > # 3 0x0000000000000000 > # 4 _ZN8facebook5velox4dwio6common31SelectiveStructColumnReaderBase4readEiN5folly5RangeIPKiEEPKm > # 5 _ZN8facebook5velox4dwio6common31SelectiveStructColumnReaderBase4nextEmRSt10shared_ptrINS0_10BaseVectorEEPKNS2_8MutationE > # 6 _ZN8facebook5velox4dwrf13DwrfRowReader4nextEmRSt10shared_ptrINS0_10BaseVectorEEPKNS0_4dwio6common8MutationE > # 7 _ZN8facebook5velox9connector4hive14HiveDataSource4nextEmRN5folly10SemiFutureINS4_4UnitEEE > # 8 _ZN8facebook5velox4exec9TableScan9getOutputEv > # 9 _ZN8facebook5velox4exec6Driver11runInternalERSt10shared_ptrIS2_ERS3_INS1_13BlockingStateEERS3_INS0_9RowVectorEE > # 10 _ZN8facebook5velox4exec6Driver4nextERSt10shared_ptrINS1_13BlockingStateEE > # 11 _ZN8facebook5velox4exec4Task4nextEPN5folly10SemiFutureINS3_4UnitEEE > # 12 _ZN6gluten24WholeStageResultIterator4nextEv > # 13 Java_io_glutenproject_vectorized_ColumnarBatchOutIterator_nativeHasNext > # 14 0x00007f794d1a3a34 > ``` > > and I see the code in velox (SelectiveDecimalReader::read): > > ``` > VELOX_CHECK(!scanSpec_->filter()); > ``` > > So selectiveDecimalReader can't have any filters. Actually, Velox doesn't support pushing down HUGEINT filters. @jiangjiangtian, thanks for your feedback. Not sure whether parquet read has issue on HUGEINT filter. cc @rui-mo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
