zhztheplayer opened a new pull request, #6554: URL: https://github.com/apache/incubator-gluten/pull/6554
1. Use the old way before https://github.com/apache/incubator-gluten/pull/5770 for block reservation because * It uses same algorithm for `diff < 0` and `diff > 0` so simplify code * It reduces code branches 2. Code `peakBytes_.store(std::max(peakBytes_.load(), usedBytes_.load()))` is still not thread-safe so needs to be locked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
