yma11 commented on code in PR #6049:
URL: https://github.com/apache/incubator-gluten/pull/6049#discussion_r1687347930


##########
gluten-core/src/main/scala/org/apache/gluten/execution/DataSourceScanTransformerRegister.scala:
##########
@@ -30,13 +30,13 @@ trait DataSourceScanTransformerRegister {
   /**
    * The class name that used to identify what kind of datasource this is。
    *
-   * For DataSource V1, it should be the child class name of
-   * [[org.apache.spark.sql.execution.datasources.FileIndex]].
+   * For DataSource V1, it should be relation.fileFormat like

Review Comment:
   `scanClassName` is a flag to decide which data source transformer should be 
triggered during register, such as delta, iceberg, hudi, etc. It's used to be 
determined by value of `org.apache.spark.sql.execution.datasources.FileIndex`, 
now in this PR we change to `relation.fileFormat`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to