summaryzb commented on code in PR #6484:
URL: https://github.com/apache/incubator-gluten/pull/6484#discussion_r1680580315
##########
.github/workflows/velox_docker.yml:
##########
@@ -511,11 +511,11 @@ jobs:
sed -i '226d'
./server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java && \
Review Comment:
If uniffle 0.9 fix the issue, maybe we could directly use the release
archive instead of recompile uniffle
##########
.github/workflows/velox_docker.yml:
##########
@@ -498,32 +498,40 @@ jobs:
export MAVEN_HOME=/usr/lib/maven && \
export PATH=${PATH}:${MAVEN_HOME}/bin && \
$MVN_CMD clean install -P${{ matrix.spark }} -Pbackends-velox
-Puniffle -DskipTests
- - name: TPC-H SF1.0 && TPC-DS SF1.0 Parquet local spark3.2 with uniffle
0.8.0
+ - name: Build for Uniffle 0.9.0
run: |
export MAVEN_HOME=/usr/lib/maven && \
export PATH=${PATH}:${MAVEN_HOME}/bin && \
export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk && \
cd /opt && \
- git clone -b branch-0.8
https://github.com/apache/incubator-uniffle.git && \
+ git clone https://github.com/apache/incubator-uniffle.git && \
cd incubator-uniffle && \
- sed -i '250d'
./server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java && \
- sed -i '228d'
./server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java && \
- sed -i '226d'
./server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java && \
- $MVN_CMD clean install -Phadoop2.8 -DskipTests
+ git checkout v0.9.0 && \
Review Comment:
`git clone -b v0.9.0 https://github.com/apache/incubator-uniffle.git` maybe
can reduce overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
