rui-mo commented on code in PR #7363: URL: https://github.com/apache/incubator-gluten/pull/7363#discussion_r1792918508
########## cpp/velox/substrait/SubstraitToVeloxPlan.cc: ########## @@ -1669,7 +1669,8 @@ bool SubstraitToVeloxPlanConverter::canPushdownOr( } Review Comment: And I suggest we add a `setOrRange` function in RangeRecorder which returns false when other conditions already exist for a field. We could return false if it returns false at L1665 in the `canPushdownOr` function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
