This is an automated email from the ASF dual-hosted git repository.
hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 8324a88500 [VL] Code clean for BasicPhysicalOperatorTransformer (#7695)
8324a88500 is described below
commit 8324a88500ebd07248a7ada2430de849dcbf61ed
Author: Mingliang Zhu <[email protected]>
AuthorDate: Tue Oct 29 09:23:31 2024 +0800
[VL] Code clean for BasicPhysicalOperatorTransformer (#7695)
---
.../BasicPhysicalOperatorTransformer.scala | 22 ++++++----------------
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git
a/gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicPhysicalOperatorTransformer.scala
b/gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicPhysicalOperatorTransformer.scala
index 684dd6ac9e..09b56a5ac7 100644
---
a/gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicPhysicalOperatorTransformer.scala
+++
b/gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicPhysicalOperatorTransformer.scala
@@ -48,7 +48,7 @@ abstract class FilterExecTransformerBase(val cond:
Expression, val input: SparkP
BackendsApiManager.getMetricsApiInstance.genFilterTransformerMetrics(sparkContext)
// Split out all the IsNotNulls from condition.
- private val (notNullPreds, otherPreds) =
splitConjunctivePredicates(cond).partition {
+ private val (notNullPreds, _) = splitConjunctivePredicates(cond).partition {
case IsNotNull(a) => isNullIntolerant(a) &&
a.references.subsetOf(child.outputSet)
case _ => false
}
@@ -170,14 +170,6 @@ abstract class FilterExecTransformerBase(val cond:
Expression, val input: SparkP
}
}
-object FilterExecTransformerBase {
- implicit class FilterExecTransformerBaseImplicits(filter:
FilterExecTransformerBase) {
- def isNoop(): Boolean = {
- filter.getRemainingCondition == null
- }
- }
-}
-
abstract class ProjectExecTransformerBase(val list: Seq[NamedExpression], val
input: SparkPlan)
extends UnaryTransformSupport
with OrderPreservingNodeShim
@@ -265,13 +257,11 @@ abstract class ProjectExecTransformerBase(val list:
Seq[NamedExpression], val in
// An alternatives for UnionExec.
case class ColumnarUnionExec(children: Seq[SparkPlan]) extends GlutenPlan {
- children.foreach(
- child =>
- child match {
- case w: WholeStageTransformer =>
- w.setOutputSchemaForPlan(output)
- case _ =>
- })
+ children.foreach {
+ case w: WholeStageTransformer =>
+ w.setOutputSchemaForPlan(output)
+ case _ =>
+ }
override def supportsColumnar: Boolean = true
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
