marin-ma commented on issue #7760: URL: https://github.com/apache/incubator-gluten/issues/7760#issuecomment-2454602599
@j7nhai Thanks for reporting this issue. The example provided in https://github.com/apache/incubator-gluten/blob/main/docs/developers/VeloxUDF.md cannot be offloaded. `hive_string_string("hello", "world")` is foldable because both inputs are constants, so the evaluation is done by Spark's optimizer rule `ConstantFolding` before Gluten can touch it. I will update the document with a proper example. We do have the UT for velox udf and the input is a column. Please check https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/test/scala/org/apache/gluten/expression/VeloxUdfSuite.scala#L163-L164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
