wForget commented on code in PR #7806:
URL: https://github.com/apache/incubator-gluten/pull/7806#discussion_r1828893187
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -723,30 +723,28 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
val trimParaSepStr = "\u2029"
// Needs to be trimmed for casting to float/double/decimal
val trimSpaceStr = ('\u0000' to '\u0020').toList.mkString
+ // ISOControl characters, refer java.lang.Character.isISOControl(int)
+ val isoControlControlStr = (('\u0000' to '\u001F') ++ ('\u007F' to
'\u009F')).toList.mkString
// scalastyle:on nonascii
- c.dataType match {
- case BinaryType | _: ArrayType | _: MapType | _: StructType | _:
UserDefinedType[_] =>
- c
- case FloatType | DoubleType | _: DecimalType =>
- c.child.dataType match {
- case StringType if GlutenConfig.getConf.castFromVarcharAddTrimNode =>
- val trimNode = StringTrim(c.child, Some(Literal(trimSpaceStr)))
- c.withNewChildren(Seq(trimNode)).asInstanceOf[Cast]
- case _ =>
- c
- }
- case _ =>
- c.child.dataType match {
- case StringType if GlutenConfig.getConf.castFromVarcharAddTrimNode =>
- val trimNode = StringTrim(
- c.child,
- Some(
- Literal(trimWhitespaceStr +
- trimSpaceSepStr + trimLineSepStr + trimParaSepStr)))
- c.withNewChildren(Seq(trimNode)).asInstanceOf[Cast]
- case _ =>
- c
+ if (GlutenConfig.getConf.castFromVarcharAddTrimNode && c.child.dataType ==
StringType) {
+ val trimStr = c.dataType match {
+ case BinaryType | _: ArrayType | _: MapType | _: StructType | _:
UserDefinedType[_] =>
+ None
+ case FloatType | DoubleType | _: DecimalType =>
+ Some(trimSpaceStr)
+ case ByteType | ShortType | IntegerType | LongType =>
Review Comment:
Makes sense, changed, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
