liuneng1994 commented on code in PR #7801:
URL: https://github.com/apache/incubator-gluten/pull/7801#discussion_r1828928573
##########
cpp-ch/local-engine/Common/QueryContext.h:
##########
@@ -40,10 +40,11 @@ class QueryContext
static QueryContext instance;
return instance;
}
- int64_t initializeQuery();
+ int64_t initializeQuery(String task_id);
DB::ContextMutablePtr currentQueryContext();
+ String currentTaskIdOrEmpty();
static std::shared_ptr<DB::ThreadGroup> currentThreadGroup();
- void logCurrentPerformanceCounters(ProfileEvents::Counters & counters)
const;
+ void logCurrentPerformanceCounters(ProfileEvents::Counters & counters,
String task_id) const;
Review Comment:
```suggestion
void logCurrentPerformanceCounters(ProfileEvents::Counters & counters,
const String& task_id) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
