PHILO-HE opened a new pull request, #7820:
URL: https://github.com/apache/incubator-gluten/pull/7820
## What changes were proposed in this pull request?
If not hidden, the below error can be reported when running gluten CPP test.
```
something wrong with flag 'velox_memory_num_shared_leaf_pools' in file
'/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/flag_definitions/flags.cpp'.
One possibility: file
'/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/flag_definitions/flags.cpp'
is being linked both statically and dynamically into this executable.
CMake Error at
/usr/local/lib64/python3.9/site-packages/cmake/data/share/cmake-3.28/Modules/GoogleTestAddTests.cmake:112
(message):
Error running test executable.
Path:
'/__w/incubator-gluten/incubator-gluten/cpp/build/velox/tests/velox_shuffle_writer_test'
```
`velox_memory_num_shared_leaf_pools` is declared in Velox under `google`
namespace. See `DEFINE_int32` used by [this velox
code](https://github.com/facebookincubator/velox/blob/main/velox/flag_definitions/flags.cpp#L21).
Even though `local: *;` is defined for version script, we have to explicitly
make all symbols under `*google::*` namespace hidden. The possible reason is
that the specified global `*facebook::velox::*` symbols cover those
`*google::*` symbols.
## How was this patch tested?
CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
