PHILO-HE commented on PR #7869: URL: https://github.com/apache/incubator-gluten/pull/7869#issuecomment-2469782707
@taiyang-li, thanks so much for letting me know your this work! I think it should be applicable to Velox backend. Maybe, you can firstly get pr merged, then try to move the proposed code to common module in another pr to see whether there is any issue reported for velox backend. BTW, I note you introduced one dedicated config for the proposed optimization rule. Maybe, it's better to have a generic config in Gluten to allow exclude any optimization rule, like Spark's `spark.sql.optimizer.excludedRules`. If it makes sense to you, it's ok to do this small improvement in a separate pr. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
