jackylee-ch commented on issue #6970: URL: https://github.com/apache/incubator-gluten/issues/6970#issuecomment-2511511530
> Option 1 > > 1. _**common config:**_ spark.gluten.sql.columnar.xxx => spark.gluten.xxx > 2. **_backend config:_** spark.gluten.sql.columnar.backend.velox.xxx => spark.gluten.backend.velox.xxx > > Option 2 > > 1. _**common config:**_ spark.gluten.sql.columnar.xxx => spark.gluten.common.xxx > 2. **_backend config:_** spark.gluten.sql.columnar.backend.velox.xxx => spark.gluten.velox..xxx The Option 2 looks good to me. > To achieve greater configuration flexibility, I initially wanted to reimplement ConfigEntry. The advantage of this approach is that we can customize attributes, such as "backend" to identify more customized information. Great. We can also add some module name, such as 'celeborn', 'iceberg' and so on, so we can directly recognize them in code or `Configure.md`. > For example, we cannot identify static configuration if we do so. We can use `SQLConf.registerStaticConfigKey(entry.key)` to register static configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
