baibaichen commented on code in PR #8052:
URL: https://github.com/apache/incubator-gluten/pull/8052#discussion_r1866903823
##########
cpp-ch/local-engine/Storages/Output/NormalFileWriter.h:
##########
@@ -230,20 +230,57 @@ class WriteStats : public WriteStatsBase
struct FileNameGenerator
{
- const bool pattern;
- const std::string filename_or_pattern;
+ // Align with org.apache.spark.sql.execution.FileNamePlaceHolder
+ const std::vector<std::string> placeholders = {"{id}", "{bucket}"};
Review Comment:
静态变量
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
