This is an automated email from the ASF dual-hosted git repository.
hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 05b1e7a28f [GLUTEN-8206][VL] Support collect_set in window (#8220)
05b1e7a28f is described below
commit 05b1e7a28fa8b2915b573496466cbe94c7baab9b
Author: WangGuangxin <[email protected]>
AuthorDate: Fri Dec 13 10:53:13 2024 +0800
[GLUTEN-8206][VL] Support collect_set in window (#8220)
Closes #8206
---
.../apache/gluten/execution/VeloxWindowExpressionSuite.scala | 7 ++-----
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc | 10 ----------
2 files changed, 2 insertions(+), 15 deletions(-)
diff --git
a/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxWindowExpressionSuite.scala
b/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxWindowExpressionSuite.scala
index 6ae7f392a7..fe4e94338d 100644
---
a/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxWindowExpressionSuite.scala
+++
b/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxWindowExpressionSuite.scala
@@ -18,7 +18,6 @@ package org.apache.gluten.execution
import org.apache.spark.SparkConf
import org.apache.spark.sql.Row
-import org.apache.spark.sql.execution.window.WindowExec
import org.apache.spark.sql.types._
class VeloxWindowExpressionSuite extends WholeStageTransformerSuite {
@@ -134,11 +133,9 @@ class VeloxWindowExpressionSuite extends
WholeStageTransformerSuite {
|FROM
| t
|ORDER BY 1, 2;
- |""".stripMargin,
- noFallBack = false
+ |""".stripMargin
) {
- // Velox window doesn't support collect_set
- checkSparkOperatorMatch[WindowExec]
+ checkGlutenOperatorMatch[WindowExecTransformer]
}
}
}
diff --git a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
index 163d65221d..682bf0fcd5 100644
--- a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
+++ b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
@@ -661,16 +661,6 @@ bool SubstraitToVeloxPlanValidator::validate(const
::substrait::WindowRel& windo
}
}
- // Validate supported aggregate functions.
- static const std::unordered_set<std::string> unsupportedFuncs =
{"collect_set"};
- for (const auto& funcSpec : funcSpecs) {
- auto funcName = SubstraitParser::getNameBeforeDelimiter(funcSpec);
- if (unsupportedFuncs.find(funcName) != unsupportedFuncs.end()) {
- LOG_VALIDATION_MSG(funcName + " was not supported in WindowRel.");
- return false;
- }
- }
-
// Validate groupby expression
const auto& groupByExprs = windowRel.partition_expressions();
std::vector<core::TypedExprPtr> expressions;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
