baibaichen commented on code in PR #8413: URL: https://github.com/apache/incubator-gluten/pull/8413#discussion_r1904275782
########## cpp-ch/local-engine/Functions/SparkFunctionDecimalBinaryOperator.h: ########## @@ -23,8 +23,16 @@ using BitInt128 = signed _BitInt(128); using BitUInt128 = unsigned _BitInt(128); +#if defined(__x86_64__) using BitInt256 = signed _BitInt(256); using BitUInt256 = unsigned _BitInt(256); +#else +// up to version 18, clang supports large _Bitint sizes on x86 and x86-64; Review Comment: @loudongfeng if we switch to clang 19, does it supports 256 bits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
