jackylee-ch commented on code in PR #8456:
URL: https://github.com/apache/incubator-gluten/pull/8456#discussion_r1907080739
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -191,10 +191,35 @@ object VeloxBackendSettings extends BackendSettingsApi {
}
}
- validateScheme().orElse(validateFormat()) match {
- case Some(reason) => ValidationResult.failed(reason)
- case _ => ValidationResult.succeeded
+ def validateEncryption(): Option[String] = {
+
+ val encryptionValidationEnabled =
GlutenConfig.getConf.enableEncryptedParquetFallback
Review Comment:
The config name is a little wird to me. maybe
`parquetEncryptionValidationEnabled`?
##########
backends-velox/src/main/scala/org/apache/gluten/utils/ParquetMetadataUtils.scala:
##########
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gluten.utils
+
+import org.apache.gluten.extension.ValidationResult
+import org.apache.gluten.substrait.rel.LocalFilesNode.ReadFileFormat
+import
org.apache.gluten.substrait.rel.LocalFilesNode.ReadFileFormat.ParquetReadFormat
+
+import org.apache.spark.util.SerializableConfiguration
+
+import org.apache.hadoop.conf.Configuration
+import org.apache.hadoop.fs.{FileSystem, LocatedFileStatus, Path,
RemoteIterator}
+import org.apache.parquet.crypto.ParquetCryptoRuntimeException
+import org.apache.parquet.hadoop.ParquetFileReader
+
+object ParquetMetadataUtils {
+
+ /**
+ * Validates whether Parquet encryption is enabled for the given paths.
+ *
+ * - If the file format is not Parquet, skip this check and return success.
+ * - If there is at least one Parquet file with encryption enabled, fail
the validation.
+ *
+ * @param format
+ * File format, e.g., `ParquetReadFormat`
+ * @param rootPaths
+ * List of file paths to scan
+ * @param serializableHadoopConf
+ * Optional Hadoop configuration
+ * @return
+ * [[ValidationResult]] validation success or failure
+ */
+ def validateEncryption(
+ format: ReadFileFormat,
+ rootPaths: Seq[String],
+ serializableHadoopConf: Option[SerializableConfiguration]
+ ): ValidationResult = {
+ if (format != ParquetReadFormat || rootPaths.isEmpty) {
+ return ValidationResult.succeeded
+ }
+
+ val conf = serializableHadoopConf.map(_.value).getOrElse(new
Configuration())
+
+ rootPaths.foreach {
+ rootPath =>
+ val fs = new Path(rootPath).getFileSystem(conf)
+ try {
+ val encryptionDetected =
+ checkForEncryptionWithLimit(fs, new Path(rootPath), conf,
fileLimit = 10)
+ if (encryptionDetected) {
+ return ValidationResult.failed("Encrypted Parquet file detected.")
+ }
+ } catch {
+ case e: Exception =>
+ }
+ }
+ ValidationResult.succeeded
+ }
+
+ /**
+ * Check any Parquet file under the given path is encrypted using a recursive
+ * iterator. Only the first `fileLimit` files are processed for efficiency.
+ *
+ * @param fs
+ * FileSystem to use
+ * @param path
+ * Root path to check
+ * @param conf
+ * Hadoop configuration
+ * @param fileLimit
+ * Maximum number of files to inspect
+ * @return
+ * True if an encrypted file is detected, false otherwise
+ */
+ private def checkForEncryptionWithLimit(
+ fs: FileSystem,
+ path: Path,
+ conf: Configuration,
+ fileLimit: Int
+ ): Boolean = {
+
+ val filesIterator: RemoteIterator[LocatedFileStatus] = fs.listFiles(path,
true)
+ var checkedFileCount = 0
+ while (filesIterator.hasNext && checkedFileCount < fileLimit) {
+ val fileStatus = filesIterator.next()
+ checkedFileCount += 1
+ try {
+ ParquetFileReader.readFooter(conf, fileStatus.getPath).toString
Review Comment:
Is it a better way to check encrypted metadata than use the Exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
