jkhaliqi commented on code in PR #8470:
URL: https://github.com/apache/incubator-gluten/pull/8470#discussion_r1907909592
##########
cpp/velox/tests/Substrait2VeloxPlanValidatorTest.cc:
##########
@@ -60,7 +60,7 @@ class Substrait2VeloxPlanValidatorTest : public
exec::test::HiveConnectorTestBas
TEST_F(Substrait2VeloxPlanValidatorTest, group) {
std::string subPlanPath = FilePathGenerator::getDataFilePath("group.json");
- ::substrait::Plan substraitPlan;
+ ::substrait::Plan substraitPlan{};
Review Comment:
Use of Uninitialized
Variable@cpp/velox/tests/[Substrait2VeloxPlanValidatorTest.cc:65](http://substrait2veloxplanvalidatortest.cc:65/)
##########
cpp/velox/tests/Substrait2VeloxPlanValidatorTest.cc:
##########
@@ -41,7 +41,7 @@ class Substrait2VeloxPlanValidatorTest : public
exec::test::HiveConnectorTestBas
bool validatePlan(std::string file) {
std::string subPlanPath = FilePathGenerator::getDataFilePath(file);
- ::substrait::Plan substraitPlan;
+ ::substrait::Plan substraitPlan{};
Review Comment:
Use of Uninitialized
Variable@cpp/velox/tests/[Substrait2VeloxPlanValidatorTest.cc:65](http://substrait2veloxplanvalidatortest.cc:45/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
