jkhaliqi commented on code in PR #8474:
URL: https://github.com/apache/incubator-gluten/pull/8474#discussion_r1911688181
##########
cpp/velox/shuffle/VeloxShuffleReader.cc:
##########
@@ -440,7 +440,7 @@ std::shared_ptr<ColumnarBatch>
VeloxSortShuffleReaderDeserializer::deserializeTo
auto buffer = cur->second;
const auto* rawBuffer = buffer->as<char>();
while (rowOffset_ < cur->first && readRows < batchSize_) {
- auto rowSize = *(RowSizeType*)(rawBuffer + byteOffset_) -
sizeof(RowSizeType);
+ auto rowSize = *(static_cast<RowSizeType*>(rawBuffer + byteOffset_)) -
sizeof(RowSizeType);
Review Comment:
No reason updating all to be one liner, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
