zhztheplayer commented on code in PR #8321:
URL: https://github.com/apache/incubator-gluten/pull/8321#discussion_r1914389620


##########
gluten-substrait/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -89,6 +90,22 @@ message ReadRel {
     google.protobuf.Any detail = 1;
   }
 
+  // Used to KafkaBatch or KafkaContinuous source
+  message StreamKafka {
+    message TopicPartition {
+      string topic = 1;
+      int32 partition = 2;
+    }
+
+    TopicPartition topic_partition = 1;
+    int64 start_offset = 2;
+    int64 end_offset = 3;
+    map<string, string> params = 4;
+    int64 poll_timeout_ms = 5;
+    bool  fail_on_data_loss = 6;
+    bool include_headers = 7;
+  }

Review Comment:
   Perhaps update 
https://github.com/apache/incubator-gluten/blob/main/docs/developers/SubstraitModifications.md
 as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to