zhztheplayer commented on code in PR #8679:
URL: https://github.com/apache/incubator-gluten/pull/8679#discussion_r1945755316


##########
pom.xml:
##########
@@ -978,6 +985,7 @@
       <properties>
         <platform>linux</platform>
         <arch>amd64</arch>
+        
<os.full.name>${os.detected.release}_${os.detected.release.version}_${os.detected.arch}</os.full.name>

Review Comment:
   Shall we use `<os.full.name>${platform}_${arch}</os.full.name>` for linux as 
well?
   
   Given https://github.com/apache/incubator-gluten/pull/6942 was merged later 
than https://github.com/apache/incubator-gluten/pull/4529
   
   cc @Yohahaha 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to