PHILO-HE commented on code in PR #8743: URL: https://github.com/apache/incubator-gluten/pull/8743#discussion_r1961193627
########## cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc: ########## @@ -259,6 +259,57 @@ bool SubstraitToVeloxPlanValidator::validateLiteral( return true; } +bool SubstraitToVeloxPlanValidator::isDeniedCast( Review Comment: Preferred function name: `isSupportedCast`. Then return false for unsupported case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
