This is an automated email from the ASF dual-hosted git repository.

yangzy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new 5e5a0a25b1 [VL] Skip PartialProjectRule when 
spark.gluten.sql.columnar.partial.project is false (#8773)
5e5a0a25b1 is described below

commit 5e5a0a25b133d3ff53a021853a39fb56f9b6665d
Author: Yang Zhang <[email protected]>
AuthorDate: Wed Feb 19 21:20:51 2025 +0800

    [VL] Skip PartialProjectRule when spark.gluten.sql.columnar.partial.project 
is false (#8773)
---
 .../org/apache/gluten/execution/ColumnarPartialProjectExec.scala      | 3 ---
 .../main/scala/org/apache/gluten/extension/PartialProjectRule.scala   | 4 ++++
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala
 
b/backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala
index 435fd239b3..500c70fefa 100644
--- 
a/backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala
+++ 
b/backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarPartialProjectExec.scala
@@ -147,9 +147,6 @@ case class ColumnarPartialProjectExec(original: 
ProjectExec, child: SparkPlan)(
   }
 
   override protected def doValidateInternal(): ValidationResult = {
-    if (!GlutenConfig.get.enableColumnarPartialProject) {
-      return ValidationResult.failed("Config disable this feature")
-    }
     if (UDFAttrNotExists) {
       return ValidationResult.failed("Attribute in the UDF does not exists in 
its child")
     }
diff --git 
a/backends-velox/src/main/scala/org/apache/gluten/extension/PartialProjectRule.scala
 
b/backends-velox/src/main/scala/org/apache/gluten/extension/PartialProjectRule.scala
index 73d1651e2f..f345a9a40c 100644
--- 
a/backends-velox/src/main/scala/org/apache/gluten/extension/PartialProjectRule.scala
+++ 
b/backends-velox/src/main/scala/org/apache/gluten/extension/PartialProjectRule.scala
@@ -16,6 +16,7 @@
  */
 package org.apache.gluten.extension
 
+import org.apache.gluten.config.GlutenConfig
 import org.apache.gluten.execution.ColumnarPartialProjectExec
 
 import org.apache.spark.sql.SparkSession
@@ -24,6 +25,9 @@ import org.apache.spark.sql.execution.{ProjectExec, SparkPlan}
 
 case class PartialProjectRule(spark: SparkSession) extends Rule[SparkPlan] {
   override def apply(plan: SparkPlan): SparkPlan = {
+    if (!GlutenConfig.get.enableColumnarPartialProject) {
+      return plan
+    }
     plan.transformUp {
       case plan: ProjectExec =>
         val transformer = ColumnarPartialProjectExec.create(plan)


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to