baibaichen commented on code in PR #8796:
URL: https://github.com/apache/incubator-gluten/pull/8796#discussion_r1964644673
##########
cpp-ch/local-engine/Storages/SubstraitSource/ReadBufferBuilder.cpp:
##########
@@ -561,12 +561,17 @@ class S3FileReadBufferBuilder : public ReadBufferBuilder
std::string ak;
std::string sk;
+ std::string use_virtual_addressing;
+ bool addressing_type = false;
tryGetString(settings, BackendInitializerUtil::HADOOP_S3_ACCESS_KEY,
ak);
tryGetString(settings, BackendInitializerUtil::HADOOP_S3_SECRET_KEY,
sk);
+ tryGetString(settings,
BackendInitializerUtil::HADOOP_S3_USE_VIRTUAL_ADDRESSING,
use_virtual_addressing);
const DB::Settings & global_settings =
context->getGlobalContext()->getSettingsRef();
const DB::Settings & local_settings = context->getSettingsRef();
+ std::transform(use_virtual_addressing.begin(),
use_virtual_addressing.end(), use_virtual_addressing.begin(), ::tolower);
Review Comment:
use boost toLower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
