PHILO-HE commented on code in PR #8320:
URL: https://github.com/apache/incubator-gluten/pull/8320#discussion_r1982799267
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -700,6 +702,64 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
GenericExpressionTransformer(substraitExprName, children, expr)
}
+ /** Generate an expression transformer to transform JsonToStructs to
Substrait. */
+ override def genFromJsonTransformer(
+ substraitExprName: String,
+ children: Seq[ExpressionTransformer],
+ expr: JsonToStructs): ExpressionTransformer = {
+ val enablePartialResults =
+ try {
+
SQLConf.get.getConfString(s"spark.sql.json.enablePartialResults").toBoolean
Review Comment:
Can we simplify this part to the below? This function may internally handle
undefined key by returning the given default value.
```
SQLConf.get.getConfString("spark.sql.json.enablePartialResults",
"false").toBoolean
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
