This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 92b05a8989 [GLUTEN-8313][VL] Enable json_array_length (#8314)
92b05a8989 is described below
commit 92b05a898994a3be88225eb1c77ea7b5510c8bd6
Author: WangGuangxin <[email protected]>
AuthorDate: Mon Mar 10 17:03:35 2025 +0800
[GLUTEN-8313][VL] Enable json_array_length (#8314)
---
.../apache/gluten/execution/JsonFunctionsValidateSuite.scala | 2 +-
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc | 11 ++---------
docs/velox-backend-scalar-function-support.md | 2 +-
3 files changed, 4 insertions(+), 11 deletions(-)
diff --git
a/backends-velox/src/test/scala/org/apache/gluten/execution/JsonFunctionsValidateSuite.scala
b/backends-velox/src/test/scala/org/apache/gluten/execution/JsonFunctionsValidateSuite.scala
index 21524e323a..fc118a1e09 100644
---
a/backends-velox/src/test/scala/org/apache/gluten/execution/JsonFunctionsValidateSuite.scala
+++
b/backends-velox/src/test/scala/org/apache/gluten/execution/JsonFunctionsValidateSuite.scala
@@ -47,7 +47,7 @@ class JsonFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- ignore("json_array_length") {
+ test("json_array_length") {
runQueryAndCompare(
s"select *, json_array_length(string_field1) " +
s"from datatab limit
5")(checkGlutenOperatorMatch[ProjectExecTransformer])
diff --git a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
index 2494abe976..35f0c7d2ea 100644
--- a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
+++ b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
@@ -58,15 +58,8 @@ const std::unordered_set<std::string> kRegexFunctions = {
"regexp_replace",
"rlike"};
-const std::unordered_set<std::string> kBlackList = {
- "split_part",
- "factorial",
- "json_array_length",
- "trunc",
- "sequence",
- "approx_percentile",
- "get_array_struct_fields",
- "map_from_arrays"};
+const std::unordered_set<std::string> kBlackList =
+ {"split_part", "factorial", "trunc", "sequence", "approx_percentile",
"get_array_struct_fields", "map_from_arrays"};
} // namespace
bool SubstraitToVeloxPlanValidator::parseVeloxType(
diff --git a/docs/velox-backend-scalar-function-support.md
b/docs/velox-backend-scalar-function-support.md
index b8f83b07fe..ea8c58cac9 100644
--- a/docs/velox-backend-scalar-function-support.md
+++ b/docs/velox-backend-scalar-function-support.md
@@ -179,7 +179,7 @@
|-------------------|---------------------|----------|----------------|
| from_json | JsonToStructs | | |
| get_json_object | GetJsonObject | S | |
-| json_array_length | LengthOfJsonArray | | |
+| json_array_length | LengthOfJsonArray | S | |
| json_object_keys | JsonObjectKeys | | |
| json_tuple | JsonTuple | S | |
| schema_of_json | SchemaOfJson | | |
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
