ArnavBalyan commented on PR #8950: URL: https://github.com/apache/incubator-gluten/pull/8950#issuecomment-2727164053
> As the APIs are mostly `public static`, I think the synchronisations are not completely meaningless. But one problem is the synchronisations code is a little bit messy. Can we use a simple way to synchronize the code? E.g., by simply adding `synchronzized` keyword to all the public methods. Performance will not be an issue here, the APIs are expected only to be called for a few times. Yes agreed, moved to publish synchronization and removed the internal ones, code should be cleaner that way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
